Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COR-175] Publish crates #83

Merged
merged 44 commits into from
Feb 6, 2023
Merged

[COR-175] Publish crates #83

merged 44 commits into from
Feb 6, 2023

Conversation

sjmiller609
Copy link
Contributor

@sjmiller609 sjmiller609 commented Feb 5, 2023

On PR to main or release branch, fail if a crate has been modified but the version in Cargo.toml is already published to crates.io.

On push to main or release branch, publish all crates, skipping any which already have their versions published.

DRY_RUN="--dry-run"
fi

cargo publish ${DRY_RUN} --token ${{ inputs.cargo-registry-token }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--dry-run flag does not fail when the version is already published, so that is why we have another step before this one that can conditionally fail if the version is already published.

coredb-cli/README.md Outdated Show resolved Hide resolved
@sjmiller609 sjmiller609 changed the title [COR-175] Check that updated crates have their version updated [COR-175] Publish crates from main or release branches Feb 5, 2023
@sjmiller609 sjmiller609 marked this pull request as ready for review February 5, 2023 22:25
@sjmiller609 sjmiller609 changed the title [COR-175] Publish crates from main or release branches [COR-175] Publish crates Feb 5, 2023
@sjmiller609 sjmiller609 marked this pull request as draft February 6, 2023 01:42
@sjmiller609 sjmiller609 marked this pull request as ready for review February 6, 2023 20:00
@sjmiller609 sjmiller609 merged commit c39f7b4 into main Feb 6, 2023
@sjmiller609 sjmiller609 deleted the core-175/cargo branch February 6, 2023 20:13
sjmiller609 added a commit that referenced this pull request Dec 5, 2023
sjmiller609 pushed a commit that referenced this pull request Dec 5, 2023
* adding in backup, serviceAccountTemplate and setting up new coredb objects

* refactor the code to work a bit more effeciently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants