Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tembo ai app #837

Merged
merged 5 commits into from
Jun 6, 2024
Merged

tembo ai app #837

merged 5 commits into from
Jun 6, 2024

Conversation

ChuckHend
Copy link
Member

@ChuckHend ChuckHend commented Jun 6, 2024 •
edited
Loading

  • adds a new app for the tembo-ai proxy
  • updates rag app to work with appropriate env var + guc

@ChuckHend ChuckHend marked this pull request as ready for review June 6, 2024 19:54
@ChuckHend ChuckHend requested a review from jasonmp85 as a code owner June 6, 2024 19:54
ChuckHend
ChuckHend commented Jun 6, 2024
View reviewed changes
tembo-stacks/src/apps/embeddings.yaml
@@ -57,11 +57,11 @@ trunk_installs:
- name: pg_cron
version: 1.6.2
- name: pgmq
version: 1.1.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

embeddings app should have been previously updated, but it was not

jasonmp85
jasonmp85 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@jasonmp85 jasonmp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the placeholder values, but otherwise looks good.

tembo-stacks/src/apps/ai.yaml
- name: vectorize.tembo_service_url
value: http://${NAMESPACE}-ai-proxy:8080/v1
- name: vectorize.tembo_jwt
value: placeholder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the value: placeholder mean here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting it to a "not null" for Tembo cloud users.

@ChuckHend ChuckHend merged commit f73ddc1 into main Jun 6, 2024
7 checks passed
@ChuckHend ChuckHend deleted the rag-envs branch June 6, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmp85 jasonmp85 jasonmp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChuckHend @jasonmp85