make sure to suspend backups if the instance is hibernated #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhudson
requested review from
sjmiller609,
ianstanton and
ChuckHend
as code owners
nhudson
commented
Jul 10, 2024
| @@ -123,7 +124,7 @@ pub(crate) async fn update_coredb_status( | |||
| .await | |||
| } | |||
|
|
|||
| // patch_cluster_merge takes a CoreDB, Cluster and serde_json::Value and patch merges the Cluster with the new spec | |||
| // patch_cluster_merge takes a CoreDB, context and serde_json::Value and patch merges the Cluster with the new spec | |||
nhudson
commented
Jul 10, 2024
| @@ -187,7 +213,7 @@ pub(crate) fn update_restarted_at( | |||
| restart_annotation_updated | |||
| } | |||
|
|
|||
| // patch_cluster is a async function that takes a CNPG cluster and patch applys it with the new spec | |||
| // patch_cluster is a async function that takes a CNPG cluster and patch applies it with the new spec | |||
nhudson
commented
Jul 10, 2024
| @@ -484,7 +484,7 @@ async fn get_trunk_project_version( | |||
| // Check if version is provided in cdb.spec.trunk_installs | |||
| for trunk_install in &cdb.spec.trunk_installs { | |||
| if trunk_install.name == trunk_project_name { | |||
| trunk_project_version = trunk_install.version.clone(); | |||
| trunk_project_version.clone_from(&trunk_install.version); | |||
There was a problem hiding this comment.
Flx clippy warning
nhudson
commented
Jul 10, 2024
| @@ -529,7 +529,7 @@ mod tests { | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_get_latest_trunk_project_version() { | |||
| let result = get_latest_trunk_project_metadata("pgmq".into()).await; | |||
| let result = get_latest_trunk_project_metadata("pgmq").await; | |||
There was a problem hiding this comment.
Fix clippy warning
bonesmoses
approved these changes
Jul 10, 2024
nhudson
commented
Jul 10, 2024
Comment on lines
179
to
184
| patch_scheduled_backup_merge(cdb, ctx, patch_scheduled_backup_spec.clone()).await?; | ||
| info!( | ||
| "Toggled scheduled backup suspend of {} to '{}'", | ||
| name, scheduled_backup_value | ||
| ); | ||
|
|
There was a problem hiding this comment.
I feel like this is redundant.
Comment on lines
150
to
157
| if !scheduled_backup_suspend_status && cdb.spec.stop { | ||
| patch_scheduled_backup_merge(cdb, ctx, patch_scheduled_backup_spec.clone()).await?; | ||
| info!( | ||
| "Toggled scheduled backup suspend of {} to '{}'", | ||
| name, scheduled_backup_value | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
This part should handle the case where instances are already paused but the scheduled backup is not suspended.
This will not un-suspend the backups though.
sjmiller609
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some logic to patch the
ScheduledBackupto suspend backups for paused instances. This causes quite a bit of contention in the CNPG operator if you do not. Basically reconciling the backups for all paused instances every 30 seconds.Fixes: CLOUD-1009