Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log unhandled errors #876

Merged
merged 1 commit into from
Jul 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions inference-gateway/src/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// All internal errors map to PlatformError
// PlatformError maps to ErrorResponse

use log;
use serde::ser::SerializeMap;
use serde::Serialize;
use sqlx::error::Error as DbError;
Expand Down Expand Up @@ -75,7 +76,7 @@ pub enum PlatformError {
S3Error(String),
}

// PUBLIC FACING ERROR RESPOSNES
// PUBLIC FACING ERROR RESPONSES
#[derive(Error, Debug)]
pub enum ErrorResponse {
#[error("{0}")]
Expand Down Expand Up @@ -110,9 +111,13 @@ impl ResponseError for PlatformError {
PlatformError::NotFoundError(_) => ErrorResponse::NotFound(self.to_string()),
PlatformError::InvalidQuery(_) => ErrorResponse::BadRequest(self.to_string()),
PlatformError::ValueError(_) => ErrorResponse::BadRequest(self.to_string()),
_ => ErrorResponse::InternalServerError(
"Internal Server Error. Please contact support".to_string(),
),
_ => {
// log the error locally
log::error!("Unhandled Error: {:?}", self.to_string());
ErrorResponse::InternalServerError(
"Internal Server Error. Please contact support".to_string(),
)
}
};
HttpResponse::build(self.status_code()).json(resp)
}
Expand Down
Loading