Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update toml dependency and refactor Extension struct #902

Merged
merged 8 commits into from
Aug 12, 2024
Merged

Update toml dependency and refactor Extension struct #902

merged 8 commits into from
Aug 12, 2024

Conversation

joshuajerin
Copy link
Contributor

@joshuajerin joshuajerin commented Aug 7, 2024 •
edited
Loading

Some Minor changes needed for Tembo.toml Endpoint

sjmiller609
sjmiller609 reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this new struct redundant of pub struct InstanceSettings?

@joshuajerin
Copy link
Contributor Author

joshuajerin commented Aug 7, 2024 •
edited
Loading

Yes it is. I made a simplified struct to implement it from the Instance struct in control plane

@joshuajerin joshuajerin changed the title Tembo Toml Struct Update toml dependency and refactor Extension struct Aug 9, 2024
vrmiguel
vrmiguel reviewed Aug 9, 2024
View reviewed changes
tembo-cli/src/cmd/apply.rs Outdated Show resolved Hide resolved
@joshuajerin joshuajerin merged commit 387d724 into main Aug 12, 2024
7 checks passed
@joshuajerin joshuajerin deleted the cloud-406 branch August 12, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjmiller609 sjmiller609 sjmiller609 approved these changes

@shahadarsh shahadarsh Awaiting requested review from shahadarsh shahadarsh is a code owner

@DarrenBaldwin07 DarrenBaldwin07 Awaiting requested review from DarrenBaldwin07 DarrenBaldwin07 is a code owner

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuajerin @sjmiller609 @vrmiguel