Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tembo-cli: fix clippy + update tembo-stacks and controller crates #977

Merged
merged 3 commits into from
Sep 25, 2024
Merged

tembo-cli: fix clippy + update tembo-stacks and controller crates #977

merged 3 commits into from
Sep 25, 2024

Conversation

ChuckHend
Copy link
Member

@ChuckHend ChuckHend commented Sep 25, 2024 •
edited
Loading

  • Updates controller and tembo-stacks crates to latest version
  • fixes bunch of clippy warnings
  • adds implementation for ai_proxy app type

This does not fix the failing test though.

@ChuckHend ChuckHend changed the title fix clippy + update tembo-stacks and controller crates tembo-cli: fix clippy + update tembo-stacks and controller crates Sep 25, 2024
@ChuckHend ChuckHend marked this pull request as ready for review September 25, 2024 18:22
shahadarsh
shahadarsh approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@shahadarsh shahadarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test is failing but somehow its using the same instance name between tests.

@ChuckHend ChuckHend merged commit 4ea4227 into main Sep 25, 2024
7 of 8 checks passed
@ChuckHend ChuckHend deleted the update-deps branch September 25, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuajerin joshuajerin joshuajerin approved these changes

@shahadarsh shahadarsh shahadarsh approved these changes

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

@DarrenBaldwin07 DarrenBaldwin07 Awaiting requested review from DarrenBaldwin07 DarrenBaldwin07 is a code owner

@sjmiller609 sjmiller609 Awaiting requested review from sjmiller609

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChuckHend @shahadarsh @joshuajerin