Handle GCP restore URI destination path correctly #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhudson
requested review from
sjmiller609,
ianstanton and
ChuckHend
as code owners
sjmiller609
suggested changes
Sep 25, 2024
ianstanton
reviewed
Sep 26, 2024
Co-authored-by: Ian Stanton <ian@tembo.io>
ianstanton
approved these changes
Sep 26, 2024
sjmiller609
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have GCP we need to be able to set and apply the correct
destination_pathinstead of just usings3://.fixes:CLOUD-1325