tls: ERROR messages in kernel log are expected on configuration errors #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-rinat
approved these changes
Nov 5, 2019
|
It was discussed in the chat that the solution is fragile: if test fails Tempesta may remain loaded on target node and the next test will fail on start. More accurate solution is required. There are more tests affected by the issue. |
krizhanovsky
approved these changes
Nov 14, 2019
| continue | ||
| if self.oops._warn_count(err) > 0: | ||
| self.oops_ignore = [] | ||
| raise Exception("%s happened during test on Tempesta" % err) |
There was a problem hiding this comment.
Don't we need to do the same for testers/stress.py?
There was a problem hiding this comment.
Yes, missed that for some reason. I've added the same interface for stress test. I will merge the PR as soon the tests on CI will pass
Now disabling requires tear_down() redefinition, it's mostly buggy because of copy-paste lasiness and issues. Just add error names to be ignored to oops_ignore array, no teardown redefinition is required
vankoven
force-pushed
the
ik-fix-tls-test-fail
branch
from
c260622 to
118e187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition to #143