Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite pairing test #556

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Rewrite pairing test #556

merged 1 commit into from
Dec 25, 2023

Conversation

Vitaly-Skopets
Copy link
Contributor

Issue

#56 by @krizhanovsky

Description

The Pairing test suite rewrite with used framework.tester.TempestaTest

@Vitaly-Skopets Vitaly-Skopets added Infrastructure The framework reworking and extensions good to start Start form this tasks if you're new in the framework labels Dec 19, 2023
@Vitaly-Skopets Vitaly-Skopets self-assigned this Dec 19, 2023
RomanBelozerov
RomanBelozerov requested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@RomanBelozerov RomanBelozerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should not use chains in this test. This is part of old framework and it needed for check all responses/requests in tests. But this test checks a Tempesta behavior when TCP connection is disconnected by client.

msg_sequence/test_pairing.py Outdated Show resolved Hide resolved
msg_sequence/test_pairing.py Outdated Show resolved Hide resolved
msg_sequence/test_pairing.py Outdated Show resolved Hide resolved
@Vitaly-Skopets Vitaly-Skopets force-pushed the VitalySkopets/56-rewrite-pairing-test branch from d01d752 to b507c8e Compare December 21, 2023 13:02
@RomanBelozerov RomanBelozerov self-requested a review December 21, 2023 15:42
RomanBelozerov
RomanBelozerov approved these changes Dec 22, 2023
View reviewed changes
msg_sequence/test_pairing.py Outdated Show resolved Hide resolved
@Vitaly-Skopets Vitaly-Skopets force-pushed the VitalySkopets/56-rewrite-pairing-test branch 2 times, most recently from 657299f to d9294cb Compare December 22, 2023 13:46
@Vitaly-Skopets Vitaly-Skopets force-pushed the VitalySkopets/56-rewrite-pairing-test branch from d9294cb to f027c01 Compare December 22, 2023 19:06
@Vitaly-Skopets Vitaly-Skopets merged commit 3a73c78 into master Dec 25, 2023
1 check passed
@Vitaly-Skopets Vitaly-Skopets deleted the VitalySkopets/56-rewrite-pairing-test branch February 19, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanBelozerov RomanBelozerov RomanBelozerov approved these changes

Assignees

@Vitaly-Skopets Vitaly-Skopets

Labels
good to start Start form this tasks if you're new in the framework Infrastructure The framework reworking and extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vitaly-Skopets @RomanBelozerov