rework deproxy server #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitaly-Skopets
approved these changes
Feb 5, 2024
mbabitski-t
suggested changes
Feb 6, 2024
framework/deproxy_server.py
Outdated
| # This parameter controls whether to keep original data with the request | ||
| # (See deproxy.HttpMessage.original_data) | ||
| self.keep_original_data = kwargs.pop("keep_original_data", None) | ||
| class StaticDeproxyServer(asyncore.dispatcher, stateful.Stateful, port_checks.FreePortsChecker): |
There was a problem hiding this comment.
-
Maybe we should create a base class from scratch, rather than use an async one, because we almost never use async in tests.
-
asyncore.dispatcheris deprecated in favor ofasyncio.ProtocolDeprecated since version 3.6, will be removed in version 3.12: The asyncore module is deprecated (see PEP 594 for details). Please use asyncio instead.
There was a problem hiding this comment.
Yes, I think it is a good idea. I created #573 issue about this.
… The class Server `helpers/deproxy.py` should be removed after changing old tests. The `BaseDeproxyServer` and `StaticDeproxyServer` were merged because inheritance makes it harder to work here. We have base class `asyncore.dispatcher`.
…e them in tests.
…es used in tests are available via `property`.
…t style. All variables with `__` changed to `_` because the main idea for this - restrict external access, but python does not restrict access anyway.
RomanBelozerov
force-pushed
the
rb-56-rework-deproxy-server
branch
from
5e953be to
2fe124d
Compare
… `ServerConnection.handle_close`. This method is called when FIN or RST is received from Tempesta.
mbabitski-t
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.