Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework tail_lock to provide it usability in kernel code. #1859

Closed
EvgeniiMekhanik opened this issue Apr 6, 2023 · 1 comment · Fixed by #1886
Closed

Rework tail_lock to provide it usability in kernel code. #1859

EvgeniiMekhanik opened this issue Apr 6, 2023 · 1 comment · Fixed by #1886
Assignees
@EvgeniiMekhanik
Labels
bug crucial
Milestone
0.7 - HTTP/2

Comments

@EvgeniiMekhanik
Copy link
Contributor

Motivation

Currently if tail_lock is set when skb is passed to kernel code, BUG_ON is fire. We should rework tail_lock or appropriate functions in kernel code. They should work with skb with tail_lock
@EvgeniiMekhanik EvgeniiMekhanik self-assigned this Apr 6, 2023
@krizhanovsky krizhanovsky added the question Questions and support tasks label Apr 6, 2023
@krizhanovsky krizhanovsky added this to the 0.7 - Beta milestone Apr 6, 2023
@const-t const-t mentioned this issue Apr 7, 2023
Closed
@krizhanovsky krizhanovsky modified the milestones: 0.7 - Beta, 1.0 - GA Apr 10, 2023
@krizhanovsky
Copy link
Contributor

We discussed that the BUG_ON() raises in skb_put() -> SKB_LINEAR_ASSERT(skb)

@krizhanovsky krizhanovsky modified the milestones: 1.0 - GA, 0.8 - Beta Apr 19, 2023
@krizhanovsky krizhanovsky mentioned this issue May 25, 2023
Merged
@krizhanovsky krizhanovsky modified the milestones: 0.8 - Beta, 0.7 - HTTP/2 May 26, 2023
@krizhanovsky krizhanovsky added bug crucial and removed question Questions and support tasks labels May 26, 2023
EvgeniiMekhanik added a commit that referenced this issue May 30, 2023
@EvgeniiMekhanik
Remove tail_lock hotfix code.
8c14ff2 
After fix `tail_lock` usage in kernel code
remove all `tail_lock` hotfix code.

Closes #1859
EvgeniiMekhanik added a commit that referenced this issue May 30, 2023
@EvgeniiMekhanik
Remove tail_lock hotfix code.
4506bc1 
After fix `tail_lock` usage in kernel code
remove all `tail_lock` hotfix code.

Closes #1859
@EvgeniiMekhanik EvgeniiMekhanik mentioned this issue May 30, 2023
Merged
EvgeniiMekhanik added a commit that referenced this issue May 30, 2023
@EvgeniiMekhanik
Remove tail_lock hotfix code.
d60d09a 
After fix `tail_lock` usage in kernel code
remove all `tail_lock` hotfix code.

Closes #1859
EvgeniiMekhanik added a commit that referenced this issue Jun 5, 2023
@EvgeniiMekhanik
Remove tail_lock hotfix code.
ddcdc81 
After fix `tail_lock` usage in kernel code
remove all `tail_lock` hotfix code.

Closes #1859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvgeniiMekhanik EvgeniiMekhanik

Labels
bug crucial
Projects
None yet
Milestone
0.7 - HTTP/2
Development

Successfully merging a pull request may close this issue.

Remove tail_lock hotfix code. tempesta-tech/tempesta
2 participants
@krizhanovsky @EvgeniiMekhanik