Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modification of response headers with TCP segmentation 1-2 bytes #1864

Closed
RomanBelozerov opened this issue Apr 13, 2023 · 0 comments
Closed

modification of response headers with TCP segmentation 1-2 bytes #1864

RomanBelozerov opened this issue Apr 13, 2023 · 0 comments
Assignees
@EvgeniiMekhanik
Labels
bug
Milestone
0.8 - Beta

Comments

@RomanBelozerov
Copy link
Contributor

Scope

I receive [tempesta fw] Warning: Can't delete len=1 from skb=000000005b2919ee in dmesg when server responds with TCP chunks 1-4 bytes and Tempesta rewrites/adds/deletes headers from server response.

AR: Client does not receive response;
ER: Client receive response.

Testing

Test to reproduce - some encoding tests. See PR415
@RomanBelozerov RomanBelozerov added this to the 1.0 - GA milestone Apr 13, 2023
@krizhanovsky krizhanovsky modified the milestones: 1.0 - GA, 0.8 - Beta Apr 19, 2023
EvgeniiMekhanik added a commit that referenced this issue May 18, 2023
@EvgeniiMekhanik
Fix invalid work of __ss_skb_cutoff function
f5a2163 
After `skb_fragment` call we should upodate `skb` and `ptr`
values using new values from `it`.
Also improve work of `ss_skb_cutoff_data` function. If we deal
with single skb we should update pointers in TfwStr only when
new skb was allocated during `skb_fragment`.

Closes #1864
EvgeniiMekhanik added a commit that referenced this issue May 18, 2023
@EvgeniiMekhanik
Fix invalid work of __ss_skb_cutoff function
f5b7a69 
After `skb_fragment` call we should upodate `skb` and `ptr`
values using new values from `it`.
Also improve work of `ss_skb_cutoff_data` function. If we deal
with single skb we should update pointers in TfwStr only when
new skb was allocated during `skb_fragment`.

Closes #1864
EvgeniiMekhanik added a commit that referenced this issue May 19, 2023
@EvgeniiMekhanik
Fix invalid work of __ss_skb_cutoff function
df3c6e3 
After `skb_fragment` call we should upodate `skb` and `ptr`
values using new values from `it`.
Also improve work of `ss_skb_cutoff_data` function. If we deal
with single skb we should update pointers in TfwStr only when
new skb was allocated during `skb_fragment`.

Closes #1864
EvgeniiMekhanik added a commit that referenced this issue May 19, 2023
@EvgeniiMekhanik
Fix invalid work of __ss_skb_cutoff function
bd90b8d 
After `skb_fragment` call we should upodate `skb` and `ptr`
values using new values from `it`.
Also improve work of `ss_skb_cutoff_data` function. If we deal
with single skb we should update pointers in TfwStr only when
new skb was allocated during `skb_fragment`.

Closes #1864
krizhanovsky pushed a commit that referenced this issue Jun 16, 2023
@EvgeniiMekhanik @krizhanovsky
Fix invalid work of __ss_skb_cutoff function
6b5a61c 
After `skb_fragment` call we should upodate `skb` and `ptr`
values using new values from `it`.
Also improve work of `ss_skb_cutoff_data` function. If we deal
with single skb we should update pointers in TfwStr only when
new skb was allocated during `skb_fragment`.

Closes #1864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvgeniiMekhanik EvgeniiMekhanik

Labels
bug
Projects
None yet
Milestone
0.8 - Beta
Development

No branches or pull requests
3 participants
@krizhanovsky @RomanBelozerov @EvgeniiMekhanik