Fix issues when running JS challenge #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to template unavailability
3 tasks
krizhanovsky
requested changes
Mar 28, 2020
There was a problem hiding this comment.
The changes do make sense and looks good except #1203 degradation.
…uest header First browser request always contains `text/html` token since it tries to load DOM. Even if it tries to load image. But in the same time `*/*` is forwarded in almost all browser request, thus every image, favicon and other requests are treated by Tempesta as requests allowed to run JS code. That's not true and this requests violate JS challenge conditions.
Give an empty file as favicon image, so browser never sends a `/favicon.ico`. This reduce requests during JS challenge processing from two to one. The code was borrowed from https://stackoverflow.com/questions/1321878/how-to-prevent-favicon-ico-requests
krizhanovsky
approved these changes
Mar 30, 2020
tempesta_fw/http_parser.c
Outdated
| TRY_STR("html", Req_I_AfterTextSlash, Req_I_AcceptHtml); | ||
| if (c == '*') | ||
| __FSM_I_MOVE(I_EoT); | ||
| __FSM_I_JMP(Req_I_AfterTextSlashToken); |
tempesta_fw/http_parser.c
Outdated
| @@ -5294,27 +5298,29 @@ __h2_req_parse_accept(TfwHttpReq *req, unsigned char *data, size_t len, | |||
| } | |||
|
|
|||
| __FSM_STATE(Req_I_AfterTextSlash) { | |||
| if (c == '*') | |||
| __FSM_H2_I_MOVE(I_EoT); | |||
| __FSM_I_JMP(Req_I_AfterTextSlashToken); | |||
There was a problem hiding this comment.
the same - just fall through, no need to jump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1393
Changes:
*/*token inAccept:header as allowing to send JS challengefavicon.icorequest. Empty favicon is integrated into JS challenge template.