backport #1426 to 0.6 #1427
Merged
backport #1426 to 0.6 #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Tempesta is started using systemd daemon, service management in tempesta.sh conflicts with systemd unit management. This happens because `flock` daemonizes and immediately exits. Systemd unit was configured to run `oneshot` command thus tempesta-fw.service immediately switches to state `started`. It's highly likely that Tempesta is not started by that moment. Situation may became worse if concurrent start and stop happens: flock process may be killed and lock file may become forever locked. To fix all the issues: - don't manage concurrent starts manually, it's systemd job - use ExecStopPost instead of ExecStop to call stop functions even on unclean start - set TimeoutSec to handle cases with really long commands processings, i.e. reconfiguration under heavy load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.