Mekhanik evgenii/fix 2328 2 #2333
Open
+167
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`__get_free_pages` can fails in case of ENOMEM, so we should remove WARN_ON_ONCE.
Previously there were some void functions with WARN_ON_ONCE to check errors in them. But there are a lot of cases when these functions can fail (for example ENOMEM), so remove WARN_ON_ONCE and return error.
In case when some of `crypto_alloc_*` functions fails it returns ERR_PTR not NULL, but when we call deallocation function we check if `ctx->cipher_ctx` or `md_ctx->tfm` is not NULL and try to deallocate it. We should check this pointer using `IS_ERR_OR_NULL` to avoid BUG.
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/fix-2328-2
branch
from
276e3ff to
6e9d4cc
Compare
EvgeniiMekhanik
requested review from
krizhanovsky and
const-t
and removed request for
krizhanovsky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.