FIX: Require environment variable to use DataLad #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a check on ``TEMPLATEFLOW_USE_DATALAD`` (default unset or false) which needs to evaluate to ``True`` in order to use DataLad. This fix addresses nipreps/fmriprep#1534.
yarikoptic
reviewed
Mar 13, 2019
|
|
||
| if any(not_fetched): | ||
| raise RuntimeError( | ||
| "Could not fetch template files: %s" % ', '.join(not_fetched)) |
There was a problem hiding this comment.
may be the error could include a message about TF_USE_DATALAD (if that one was not set), to instruct users about a possible way to get those files where applicable?
|
Hehehe, before adding the variable to the docs, we need to build docs at all (opened #9) |
oesteban
added a commit
that referenced
this pull request
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check on
TEMPLATEFLOW_USE_DATALAD(default unsetor false) which needs to evaluate to
Truein order to useDataLad.
This fix addresses nipreps/fmriprep#1534.