Skip to content

Commit

Permalink
addressed PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
mastermanu committed Mar 13, 2024
1 parent 9ccf3fb commit b62fc9c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions temporal/api/cloud/cloudservice/v1/request_response.proto
Original file line number Diff line number Diff line change
Expand Up @@ -239,13 +239,13 @@ message GetIncomingServicesRequest {
// The page token if this is continuing from another response - optional.
string page_token = 2;

// Filter incoming services by the namespace they route to - optional.
// Filter incoming services by the namespace they route to - optional, treated as an AND if specified.
string namespace = 3;

// Filter incoming services by the task queue they route to - optional.
// Filter incoming services by the task queue they route to - optional, treated as an AND if specified.
string task_queue = 4;

// Filter incoming services by their name - optional. Specifying this will result in zero or one results.
// Filter incoming services by their name - optional, treated as an AND if specified. Specifying this will result in zero or one results.
string name = 5;
}

Expand Down
8 changes: 4 additions & 4 deletions temporal/api/cloud/nexus/v1/message.proto
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,11 @@ message TargetCloudIncomingServiceSpec {
// A per-namespace binding from service name to destination service to invoke Nexus requests
// that are initiated by workflows.
message OutgoingService {
// The name of the outgoing service.
string name = 1;

// The namespace this outgoing service is attached to.
string namespace = 2;
string namespace = 1;

// The name of the outgoing service.
string name = 2;

// The current version of the incoming service specification.
// The next update operation must include this version.
Expand Down

0 comments on commit b62fc9c

Please sign in to comment.