New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce user group management APIs #22

Merged

codemonkeycxy merged 20 commits into main from xinyi/group-crud

May 9, 2024

Contributor

codemonkeycxy commented Apr 16, 2024 •

edited

Loading

What was changed

Introducing a new identity concept "UserGroup" with CRUD APIs that manage user group -> account/namespace access mapping

Why?

This is to enable the management of user group -> account/namespace access mapping by Temporal Cloud customers

Customers manage the user -> group mapping on their end
Customer sets up group -> account/namespace access mapping by calling these APIs
When users log in, Temporal Cloud uses the groups in user's token to perform authz

Checklist

Closes
How was this tested:

Any docs updates needed?


          Introduce group management APIs

a91d840

CLAassistant commented Apr 16, 2024 •

edited

Loading

All committers have signed the CLA.

cretz reviewed

View reviewed changes

temporal/api/cloud/identity/v1/message.proto Outdated Show resolved Hide resolved

temporal/api/cloud/cloudservice/v1/service.proto Outdated Show resolved Hide resolved

temporal/api/cloud/cloudservice/v1/service.proto Outdated Show resolved Hide resolved

temporal/api/cloud/cloudservice/v1/request_response.proto Outdated Show resolved Hide resolved

temporal/api/cloud/cloudservice/v1/service.proto Outdated Show resolved Hide resolved

anekkanti reviewed

View reviewed changes

temporal/api/cloud/identity/v1/message.proto Outdated Show resolved Hide resolved

anekkanti reviewed

View reviewed changes

temporal/api/cloud/identity/v1/message.proto Outdated Show resolved Hide resolved

anekkanti reviewed

View reviewed changes

temporal/api/cloud/cloudservice/v1/service.proto Outdated Show resolved Hide resolved

anekkanti reviewed

View reviewed changes

temporal/api/cloud/identity/v1/message.proto Outdated Show resolved Hide resolved

anekkanti reviewed

View reviewed changes

temporal/api/cloud/cloudservice/v1/request_response.proto Outdated Show resolved Hide resolved

anekkanti reviewed

View reviewed changes

temporal/api/cloud/cloudservice/v1/request_response.proto Outdated Show resolved Hide resolved

codemonkeycxy added 5 commits

April 16, 2024 13:53

d4d254d


          update http path

18103b8


          add state and async op id

ef1fa99


          mutability

c8cb84d


          wording

d0036c9

codemonkeycxy changed the title ~~Introduce group management APIs~~ Introduce user group management APIs

codemonkeycxy added 2 commits

April 16, 2024 14:29


          rename to user group

3023eed


          fix CreateUserGroupRequest

66dbd89

cretz reviewed

View reviewed changes

temporal/api/cloud/cloudservice/v1/service.proto Outdated Show resolved Hide resolved


          -> user group

0a735b1

codemonkeycxy commented

View reviewed changes

temporal/api/cloud/cloudservice/v1/service.proto Show resolved Hide resolved

codemonkeycxy added 2 commits

April 17, 2024 09:34


          update comments

1c7fa20


          consistency

0ceb782

cretz approved these changes

View reviewed changes


          fix reference

fc2f6e1

codemonkeycxy commented

View reviewed changes

temporal/api/cloud/cloudservice/v1/request_response.proto Show resolved Hide resolved

codemonkeycxy commented

View reviewed changes

temporal/api/cloud/cloudservice/v1/request_response.proto Show resolved Hide resolved

codemonkeycxy added 4 commits

April 22, 2024 14:44


          Add filter and update comment

a50075d


          update comment

f6da1b5


          change type to host_type

395bd0e


          rename to type

00383b0

codemonkeycxy added 2 commits

April 24, 2024 14:51


          update const


          update comment

9316ca7

mattkim reviewed

View reviewed changes

temporal/api/cloud/cloudservice/v1/request_response.proto Outdated Show resolved Hide resolved

mattkim reviewed

View reviewed changes

temporal/api/cloud/identity/v1/message.proto Outdated Show resolved Hide resolved

mattkim reviewed

View reviewed changes

temporal/api/cloud/identity/v1/message.proto Show resolved Hide resolved

anekkanti reviewed

View reviewed changes

temporal/api/cloud/identity/v1/message.proto Outdated Show resolved Hide resolved

anekkanti approved these changes

View reviewed changes

mattkim approved these changes

View reviewed changes

codemonkeycxy added 2 commits

May 9, 2024 15:49


          address comments


          update comment

f7a4bd6

codemonkeycxy merged commit 6e8267e into main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet