Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Replace strings with enums where ever applicable. #36

Merged
merged 9 commits into from
Oct 7, 2024

Conversation

anekkanti
Copy link
Member

@anekkanti anekkanti commented Jul 24, 2024

This a breaking change, but is backward wire compatible.
Meaning the existing clients will keep working when this change is deployed on the server
But the consumers will see compile time errors when they pull the change.

String fields being replaced with enums:

  • Namespace::state
  • User::state
  • ServivceAccount::state
  • ApiKey:state
  • AsyncOperation::state
  • NamespaceRegionStatus::state
  • AccountAccess::role
  • NamespaceAccess::permission
  • ApiKeySpec::owner_type
  • NamespaceSpec::custom_search_attributes

Replace string (base64 encoded pem certs) ca certs with a bytes field (pem certs):

  • NamespaceSpec::mtls_auth::accepted_client_ca

buf.yaml Show resolved Hide resolved
@anekkanti anekkanti merged commit 138a2ad into main Oct 7, 2024
3 checks passed
@anekkanti anekkanti deleted the abhinav/enums/identityEnums branch October 7, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants