-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add owner and finance admin roles CLD-3326 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakeelrao
reviewed
Aug 12, 2024
shakeelrao
reviewed
Aug 12, 2024
// admin - gives full access the account, including users and namespaces | ||
// developer - gives access to create namespaces on the account | ||
// read - gives read only access to the account | ||
// financeadmin - gives read only access and write access for billing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is this role ready yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. It's there for all accounts and has some permissions.
shakeelrao
approved these changes
Aug 12, 2024
captainbeardo
force-pushed
the
beardo/CLD-3326
branch
from
August 13, 2024 17:58
ae3e814
to
ed258d5
Compare
anekkanti
approved these changes
Aug 13, 2024
shivam-ajmera
pushed a commit
that referenced
this pull request
Aug 15, 2024
mastermanu
pushed a commit
to mastermanu/api-cloud
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Describe new roles
Why?
So that there is awareness of the new roles.
Checklist
Closes
https://temporalio.atlassian.net/browse/CLD-3326
How was this tested:
N/A
N/A