Add test to verify that Schedule memo can be updated #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
May 20, 2024
| "--memo", "bar=2", | ||
| ) | ||
| s.NoError(res.Err) | ||
| s.Eventually(func() bool { |
There was a problem hiding this comment.
Why "eventually"? Is this not updated immediately and does describe not return the strongly consistent value?
There was a problem hiding this comment.
Frankly, I don't know, I just copied it from the other test that updates the schedule. My guess is that it starts another workflow for the schedule in the background, and that's why it is eventually consistent...
There was a problem hiding this comment.
It sends a signal to the schedule workflow, which updates its own memo. So yes, it's not currently synchronous, sadly. We can fix this with update later.
cretz
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add a test to verify that #433 has been resolved in current server versions
Checklist
Updating Schedule with memo option not updating memo #433