Update the docker-builds repo when releases are published #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexshtin
approved these changes
May 21, 2024
cretz
reviewed
May 21, 2024
There was a problem hiding this comment.
We have used something like https://github.com/temporalio/sdk-python/blob/11a97d1ab2ebfe8c973bf396b1e14077ec611e52/.github/workflows/ci.yml#L102-L103 to run workflows from other repos before. Would that make sense here?
There was a problem hiding this comment.
We could. I copied this practically verbatim from the server work to minimize the chance of breaking it
There was a problem hiding this comment.
Done
I saw this PR was merged with no non-merge commits after this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I added a GitHub workflow that will keep the CLI submodule in temporalio/docker-builds up to date with new CLI releases.
As part of this change we're updating our internal release processes to include releasing a new version of
temporalio/admin-toolswhenever a release to the CLI is made.Why?
So that we always use the most recent CLI when building containers.