Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace runner macos-14 with macos-13 in CI tests #709

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

rodrigozhou
Copy link
Contributor

@rodrigozhou rodrigozhou commented Nov 19, 2024

What was changed

Replaced macos-14 with macos-13 to test on Intel arch.
Updated actions versions.

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the macos-14 requirement for merges. Once this is merged, I will add the macos-13 requirement.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@rodrigozhou rodrigozhou changed the title Add test status job to CI workflow to aggregate jobs results Replace runner macos-14 with macos-13 in CI tests Nov 26, 2024
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge. Then I'll update CI.

@rodrigozhou rodrigozhou merged commit 6854554 into main Dec 2, 2024
7 checks passed
@rodrigozhou rodrigozhou deleted the rodrigozhou/ci-test-status branch December 2, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants