Calculate admintools tag #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnr
reviewed
May 21, 2024
This is a bit nasty but it's due to how shallow checkouts work. We need to fetch the tag detail (then remove the shallow flag) so that git describe behaves as we want. We still use `--always` as `tctl` doesn't always seem to have a findable tag...
Co-authored-by: David Reiss <david@temporal.io>
dnr
reviewed
May 21, 2024
dnr
approved these changes
May 22, 2024
pdoerner
pushed a commit
that referenced
this pull request
May 31, 2024
## What was changed Our "release admintools" action now calculates the tag for you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Our "release admintools" action now calculates the tag for you