Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to the latest from master #398

Merged
merged 1 commit into from
Jan 11, 2024
Merged

move to the latest from master #398

merged 1 commit into from
Jan 11, 2024

Conversation

ast2023
Copy link
Contributor

@ast2023 ast2023 commented Jan 9, 2024

What was changed

The version of the API updated to the current latest commit on master

Why?

The new datastructures defined in the API required to progress development.

Checklist

@ast2023 ast2023 force-pushed the sasha/update-api-version branch from 622b27f to 257a8b3 Compare January 9, 2024 23:05
@ast2023 ast2023 enabled auto-merge (squash) January 9, 2024 23:09
@cretz
Copy link
Member

cretz commented Jan 10, 2024

I think the go.temporal.io/api needs to be updated in harness/go/go.mod and a go mod tidy run in there (may then need another go mod tidy in the root)

Also, you can run the features CLI yourself against your version of your code in temporalio/sdk-go#1319 to confirm this fix works.

features/go.mod Outdated Show resolved Hide resolved
@ast2023 ast2023 force-pushed the sasha/update-api-version branch from 4259288 to b7e6f4a Compare January 11, 2024 17:57
@ast2023 ast2023 requested a review from cretz January 11, 2024 18:07
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! If you'd like, you can run this yourself against your version of your code in temporalio/sdk-go#1319 to confirm this fix works.

@ast2023 ast2023 merged commit e140a28 into main Jan 11, 2024
20 checks passed
@ast2023 ast2023 deleted the sasha/update-api-version branch January 11, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants