Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP docker image building #541

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Add PHP docker image building #541

merged 3 commits into from
Oct 7, 2024

Conversation

roxblnfk
Copy link
Collaborator

What was changed

Added and integrated the php.Dockerfile into the build pipeline.

Why?

To be able to run PHP Harness tests similar to other SDKs, I need to add the temporaliotest/features:php image.
Part of #485

@roxblnfk roxblnfk mentioned this pull request Sep 23, 2024
Merged
28 tasks
Sushisource
Sushisource reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should just be included with #485 ?

@roxblnfk
Copy link
Collaborator Author

Actually, this was extracted from #485.
The problem is that we can't verify if #485 works in CI until we add the Docker images to the Temporal registry. For this, we will need to make yet another PR to temporalio/docker-builds.

Sushisource
Sushisource approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sure that makes sense

@josh-berry josh-berry enabled auto-merge (squash) October 7, 2024 17:07
@josh-berry josh-berry merged commit 7f5a0d9 into temporalio:main Oct 7, 2024
18 checks passed
@roxblnfk roxblnfk deleted the add-php-image branch October 7, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roxblnfk @Sushisource @josh-berry