Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sidecar containers and provide cloudsqlproxy example #107

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,18 @@ Other components (Prometheus, Kafka, Grafana) can be omitted from the installati
temporaltest . --timeout 900s
```

### Install with sidecar containers

You may need to provide your own sidecar containers.

To do so, you may look at the example for Google's `cloud sql proxy` in the `values/values.cloudsqlproxy.yaml` and pass that file to `helm install`.

Example:

```bash
~/temporal-helm$ helm install -f values/values.cloudsqlproxy.yaml temporaltest . --timeout 900s
```

### Install with your own ElasticSearch

You might already be operating an instance of ElasticSearch that you want to use with Temporal.
Expand Down
4 changes: 4 additions & 0 deletions templates/server-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ spec:
{{- end }}
resources:
{{- toYaml (default $.Values.server.resources $serviceValues.resources) | nindent 12 }}
{{- if $.Values.server.sidecarContainers }}
{{- toYaml $.Values.server.sidecarContainers | nindent 8 }}
{{- end }}

{{- with $.Values.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
Expand Down
1 change: 1 addition & 0 deletions values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ debug: false

server:
enabled: true
sidecarContainers:
image:
repository: temporalio/server
tag: 1.8.0
Expand Down
20 changes: 20 additions & 0 deletions values/values.cloudsqlproxy.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
server:
sidecarContainers:
- name: cloud-sql-proxy
image: gcr.io/cloudsql-docker/gce-proxy:1.17
command:
- "/cloud_sql_proxy"
- "-ip_address_types=PRIVATE"
- "-instances=_PROJECTNAME_:_REGION_:_INSTANCENAME_=tcp:5432"
- "-credential_file=/etc/google-cloud-key/key.json"
securityContext:
runAsNonRoot: true
volumeMounts:
- name: google-cloud-key
mountPath: /etc/google-cloud-key
readOnly: true

additionalVolumes:
- name: google-cloud-key
secret:
secretName: cloud-sql-proxy-sa