-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release and publish helm charts via a Github Action Release workflow. #457
Conversation
Chart releaser already tags before release.
Further work needed to give good instructions for using the repo version.
fa9e103
to
3e9c6e3
Compare
sed -i -e "s/^appVersion: .*/appVersion: ${{ github.event.inputs.version }}/" Chart.yaml | ||
|
||
git commit -m "Update Chart to $NEW_VERSION, Temporal v${{ github.event.inputs.version }}" Chart.yaml | ||
git push origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice; I learned a couple of things from it; grep -m
and I didn't know about the let
arithmetic at all, I thought one had to use ((...))
. Could use sed -E
to make the regex more readable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@robholland , for information, when i try https://go.temporal.io/helm-charts i have the following error when trying to install temporal.io : "gzip: invalid header" Do you have an idea why it does not work? Thanks a lot again for your amazing work :) |
Sorry, the wiring wasn't quite right, I think it's better now. Please can you try again? I'll be doing more thorough testing and documentation over the next few weeks. |
I just tried again when i saw the new version 0.33, and this time it seems to work at first sight ! thanks a lot @robholland :) |
I just have the issue #445 popping when trying to use an existing postgresql on my helm |
Are there any plans to add a folow-up documentation with Helm repo usage? |
Yep, it's on my list: #458 |
What was changed
Added a new workflow that automates the release of the Helm chart. This workflow also makes the Helm chart releases available via a helm repo: https://go.temporal.io/helm-charts.
Installation via the helm repo is not yet documented, a follow-up PR will add the repo to the documentation.
Why?
This automates some of the manual work currently performed by OSS team. This also allow users to install Temporal via Helm without having to download the repo, although they will probably still need to refer to the (rather long) values files to achieve their desired configuration.
Fixes: #330
Also technically fixes: #45 #229, but documentation needs to be updated to show users how to install from a repo.
Checklist
Closes
How was this tested:
Docs will need updating to highlight the new installation method.