Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release and publish helm charts via a Github Action Release workflow. #457

Merged
merged 8 commits into from
Jan 30, 2024

Conversation

robholland
Copy link
Contributor

@robholland robholland commented Jan 30, 2024

What was changed

Added a new workflow that automates the release of the Helm chart. This workflow also makes the Helm chart releases available via a helm repo: https://go.temporal.io/helm-charts.

Installation via the helm repo is not yet documented, a follow-up PR will add the repo to the documentation.

Why?

This automates some of the manual work currently performed by OSS team. This also allow users to install Temporal via Helm without having to download the repo, although they will probably still need to refer to the (rather long) values files to achieve their desired configuration.

Fixes: #330

Also technically fixes: #45 #229, but documentation needs to be updated to show users how to install from a repo.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?
    Docs will need updating to highlight the new installation method.

@robholland robholland requested review from a team as code owners January 30, 2024 15:42
@CLAassistant
Copy link

CLAassistant commented Jan 30, 2024

CLA assistant check
All committers have signed the CLA.

sed -i -e "s/^appVersion: .*/appVersion: ${{ github.event.inputs.version }}/" Chart.yaml

git commit -m "Update Chart to $NEW_VERSION, Temporal v${{ github.event.inputs.version }}" Chart.yaml
git push origin
Copy link

@dandavison dandavison Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice; I learned a couple of things from it; grep -m and I didn't know about the let arithmetic at all, I thought one had to use ((...)). Could use sed -E to make the regex more readable?

Copy link

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robholland robholland merged commit 82c9dfa into master Jan 30, 2024
3 checks passed
@robholland robholland deleted the rh-chart-publish branch January 30, 2024 17:31
@ghost
Copy link

ghost commented Jan 30, 2024

@robholland , for information, when i try https://go.temporal.io/helm-charts i have the following error when trying to install temporal.io : "gzip: invalid header"
To reproduce: get a rancher, add this repo, go to app catalog, install the app

Do you have an idea why it does not work?

Thanks a lot again for your amazing work :)

@robholland
Copy link
Contributor Author

Sorry, the wiring wasn't quite right, I think it's better now. Please can you try again? I'll be doing more thorough testing and documentation over the next few weeks.

@ghost
Copy link

ghost commented Jan 30, 2024

I just tried again when i saw the new version 0.33, and this time it seems to work at first sight ! thanks a lot @robholland :)

@ghost
Copy link

ghost commented Jan 30, 2024

I just have the issue #445 popping when trying to use an existing postgresql on my helm

@wrbbz
Copy link

wrbbz commented Mar 1, 2024

Are there any plans to add a folow-up documentation with Helm repo usage?

@robholland
Copy link
Contributor Author

Yep, it's on my list: #458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Tag all releases Publish temporal helm chart to a helm chart repository (e. g. Helm Hub)
4 participants