Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove standard visibility support #460

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

rodrigozhou
Copy link
Contributor

@rodrigozhou rodrigozhou commented Feb 2, 2024

What was changed

Remove standard visibility support (change plugin names mysql to mysql8 and postgres to postgres12).
Removed commands to update schema for the standard visibility case.

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@rodrigozhou rodrigozhou requested review from a team as code owners February 2, 2024 19:26
@dandavison
Copy link

dandavison commented Feb 3, 2024

I can confirm that this fixes the problem we were seeing with the DeployApplication stage of oss-cicd pipelines failing [e.g.]. Thanks for working on this!

@dandavison
Copy link

Can you add an explanation of the changes in this PR (mysql and postgres version changes, plus the removal of the update-schema command)

@rodrigozhou rodrigozhou merged commit 79d3282 into master Feb 5, 2024
3 checks passed
@rodrigozhou rodrigozhou deleted the rodrigozhou/remove-std-vis branch February 5, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants