Add support for deployment labels and annotations #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm going to wait for #539 to be merged, please then adjust this to lean on the helper, and add a similar helper for annotations. |
|
#539 is now merged. Please can you re-work the PR based on that? |
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR adds support for configuring custom labels and annotations in the main metadata of all
Deploymentworkloads:serverserver.frontendserver.historyserver.matchingserver.workeradmintoolswebWhy?
These changes were added specifically to allow for custom
serverDeploymentannotations so that a tool like stakater/Reloader may be used to auto-restart theserverwhen persistence auth keys are rotated.Checklist
Closes
How was this tested:
Local
helm templaterendering.