Fix YAML parse error when specifying two or more resource labels #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robholland
approved these changes
Oct 7, 2024
asproul
pushed a commit
to asproul/helm-charts
that referenced
this pull request
Dec 16, 2024
…poralio#579) * fix: add newline after each label to prevent parse error * fix: remove newline between default labels and resource labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR fixes a YAML parse error on temporal/templates/server-deployment.yaml (
error converting YAML to JSON: yaml: line 31: mapping values are not allowed in this context).Why?
This error is introduced in PR #539 and occurs when two or more resource labels (e.g. podLabels) are specified. It works with 1 resource label, because the parse error is caused by missing newlines after each label in the
$resourceLabelsrange. This starts to become a problem with at least 2 items.Checklist
How was this tested:
helm install -f values.yaml --set additionalLabels.additionalLabel1="additionalTest1" --set server.frontend.podLabels.label1="test1" --set server.frontend.podLabels.label2="test2" debug . --dry-run --debugAny docs updates needed?
No.