Typed search attributes in SDK #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
approved these changes
Feb 18, 2023
Sushisource
approved these changes
Feb 22, 2023
sdk-typed-search-attributes.md
Outdated
| * Each `SearchAttributeKey` has a `valueSet(value)` and a `valueUnset()` that return `SearchAttributeUpdate`s | ||
| * So Java may look like `Workflow.updateSearchAttributes(MY_ATTR1.valueSet("foo"), MY_ATTR2.valueUnset())` | ||
| * Ok that we call it "unset" instead of "delete"? | ||
| * Ok that we call it `valueSet` and `valueDelete` instead of just `set` and `delete`? |
There was a problem hiding this comment.
I think these are fine but I'd just switch it around to be setValue and unsetValue
There was a problem hiding this comment.
The reason I put the noun first is because the verb makes you think you're doing something instead of just building an update
|
I have made updates based on discussion. Namely, |
cretz
force-pushed
the
sdk-typed-search-attributes2
branch
from
9d2c07f to
473771c
Compare
cretz
force-pushed
the
sdk-typed-search-attributes2
branch
from
473771c to
7a1fb6f
Compare
|
Merging now that discussion is through. However, we're already learning things on the implementation side that are changing some of this (i.e. that we know the type of every key from the server payload). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered (until merged): https://github.com/cretz/temporal-proposals/blob/sdk-typed-search-attributes2/sdk-typed-search-attributes.md
This is a followup after discussion from #74 and supersedes that one.