Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use LA pool for the local activities execution #527

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

rustatian
Copy link
Collaborator

@rustatian rustatian commented Jun 10, 2024

Reason for This PR

closes: roadrunner-server/roadrunner#1940

Description of Changes

  • WF pool was incorrectly used to execute Local Activities.
  • Update implementation, use the general pool for A + LA.
  • Use LA execute function directly, w/o constructor like in prev. implementation.
  • Add headers to the execute function (passed to the worker).

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added B-bug Bug: bug, unhandled exception B-regression Bug: regression bugs labels Jun 10, 2024
@rustatian rustatian requested a review from wolfy-j June 10, 2024 13:54
@rustatian rustatian self-assigned this Jun 10, 2024
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian marked this pull request as ready for review June 10, 2024 14:46
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian merged commit 595f4fc into master Jun 10, 2024
10 checks passed
@rustatian rustatian deleted the fix/wrong-pool-for-la branch June 10, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: bug, unhandled exception B-regression Bug: regression bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG]: Local activities run on workflow worker pool
2 participants