Exclude codes.DeadlineExceeded from the list of retryable gRPC codes (#…

…1366)
temporalio · Jan 26, 2024 · 536b875 · 536b875
1 parent 94a5f5f
commit 536b875
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/internal/common/retry/interceptor.go b/internal/common/retry/interceptor.go
@@ -118,9 +118,12 @@ var (
 	// gRPC response codes that represent retryable errors.
 	// The following status codes are never generated by the library:
 	//    INVALID_ARGUMENT, NOT_FOUND, ALREADY_EXISTS, FAILED_PRECONDITION, ABORTED, OUT_OF_RANGE, DATA_LOSS
-	retryableCodes = []codes.Code{codes.Aborted, codes.DeadlineExceeded, codes.Internal,
+	// codes.DeadlineExceeded and codes.Canceled are not here (and shouldn't be here!)
+	// because they are coming from go context and "context errors are not retriable based on user settings"
+	// by gRPC library.
+	retryableCodes = []codes.Code{codes.Aborted, codes.Internal,
 		codes.ResourceExhausted, codes.Unavailable, codes.Unknown}
-	retryableCodesWithoutInternal = []codes.Code{codes.Aborted, codes.DeadlineExceeded,
+	retryableCodesWithoutInternal = []codes.Code{codes.Aborted,
 		codes.ResourceExhausted, codes.Unavailable, codes.Unknown}
 )