Replace ListWorkflow with DescribeWorkflowExecution in integration test

temporalio · Sep 7, 2022 · 713ef57 · 713ef57
1 parent 06d2e6d
commit 713ef57
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 30 deletions.
diff --git a/internal/workflow.go b/internal/workflow.go
@@ -1226,6 +1226,8 @@ func (wc *workflowEnvironmentInterceptor) UpsertSearchAttributes(ctx Context, at
 //		"Key2": true,
 //		"Key3": "seattle",
 //	}
+//
+// This is only supported with Temporal Server 1.18+
 func UpsertMemo(ctx Context, memo map[string]interface{}) error {
 	i := getWorkflowOutboundInterceptor(ctx)
 	return i.UpsertMemo(ctx, memo)

diff --git a/test/integration_test.go b/test/integration_test.go
@@ -2561,20 +2561,12 @@ func (ts *IntegrationTestSuite) TestUpsertMemoFromNil() {
 	time.Sleep(2 * time.Second)
 
 	// Query ES for memo
-	var nextPageToken []byte
-	resp, err := ts.client.ListWorkflow(ctx, &workflowservice.ListWorkflowExecutionsRequest{
-		Namespace:     ts.config.Namespace,
-		PageSize:      10,
-		NextPageToken: nextPageToken,
-		Query:         fmt.Sprintf("WorkflowId = '%s'", wfid),
-	})
+	resp, err := ts.client.DescribeWorkflowExecution(ctx, wfid, "")
 	ts.NoError(err)
 	ts.NotNil(resp)
 
-	ts.Greater(len(resp.Executions), 0)
-	wfExecutionInfo := resp.Executions[0]
 	// workflow execution info matches memo in ES and correct
-	ts.Equal(wfExecutionInfo.Memo, memo)
+	ts.Equal(resp.WorkflowExecutionInfo.Memo, memo)
 	ts.Equal(expectedMemo, memo)
 }
 
@@ -2622,20 +2614,12 @@ func (ts *IntegrationTestSuite) TestUpsertMemoFromEmptyMap() {
 	time.Sleep(2 * time.Second)
 
 	// Query ES for memo
-	var nextPageToken []byte
-	resp, err := ts.client.ListWorkflow(ctx, &workflowservice.ListWorkflowExecutionsRequest{
-		Namespace:     ts.config.Namespace,
-		PageSize:      10,
-		NextPageToken: nextPageToken,
-		Query:         fmt.Sprintf("WorkflowId = '%s'", wfid),
-	})
+	resp, err := ts.client.DescribeWorkflowExecution(ctx, wfid, "")
 	ts.NoError(err)
 	ts.NotNil(resp)
 
-	ts.Greater(len(resp.Executions), 0)
-	wfExecutionInfo := resp.Executions[0]
 	// workflow execution info matches memo in ES and correct
-	ts.Equal(wfExecutionInfo.Memo, memo)
+	ts.Equal(resp.WorkflowExecutionInfo.Memo, memo)
 	ts.Equal(expectedMemo, memo)
 }
 
@@ -2686,20 +2670,12 @@ func (ts *IntegrationTestSuite) TestUpsertMemoWithExistingMemo() {
 	time.Sleep(2 * time.Second)
 
 	// Query ES for memo
-	var nextPageToken []byte
-	resp, err := ts.client.ListWorkflow(ctx, &workflowservice.ListWorkflowExecutionsRequest{
-		Namespace:     ts.config.Namespace,
-		PageSize:      10,
-		NextPageToken: nextPageToken,
-		Query:         fmt.Sprintf("WorkflowId = '%s'", wfid),
-	})
+	resp, err := ts.client.DescribeWorkflowExecution(ctx, wfid, "")
 	ts.NoError(err)
 	ts.NotNil(resp)
 
-	ts.Greater(len(resp.Executions), 0)
-	wfExecutionInfo := resp.Executions[0]
 	// workflow execution info matches memo in ES and correct
-	ts.Equal(wfExecutionInfo.Memo, memo)
+	ts.Equal(resp.WorkflowExecutionInfo.Memo, memo)
 	ts.Equal(expectedMemo, memo)
 }
 

diff --git a/workflow/workflow.go b/workflow/workflow.go
@@ -494,6 +494,8 @@ func UpsertSearchAttributes(ctx Context, attributes map[string]interface{}) erro
 //		"Key2": true,
 //		"Key3": "seattle",
 //	}
+//
+// This is only supported with Temporal Server 1.18+
 func UpsertMemo(ctx Context, memo map[string]interface{}) error {
 	return internal.UpsertMemo(ctx, memo)
 }