Skip to content

Commit

Permalink
Address Quinn comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Sushisource committed Mar 13, 2023
1 parent e655cd3 commit 7b59d6f
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 7 deletions.
10 changes: 7 additions & 3 deletions client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,11 @@ type (
WorkflowUpdateHandle = internal.WorkflowUpdateHandle

// UpdateWorkerBuildIDCompatabilityOptions is the input to Client.UpdateWorkerBuildIdCompatability.
// NOTE: Experimental
UpdateWorkerBuildIDCompatabilityOptions = internal.UpdateWorkerBuildIDCompatabilityOptions

// GetWorkerBuildIDCompatabilityOptions is the input to Client.GetWorkerBuildIdCompatability.
// NOTE: Experimental
GetWorkerBuildIDCompatabilityOptions = internal.GetWorkerBuildIDCompatabilityOptions

// WorkerBuildIDVersionSets is the response for Client.GetWorkerBuildIdCompatability.
Expand Down Expand Up @@ -492,13 +494,15 @@ type (
// RequestId is used to deduplicate requests. It will be autogenerated if not set.
ResetWorkflowExecution(ctx context.Context, request *workflowservice.ResetWorkflowExecutionRequest) (*workflowservice.ResetWorkflowExecutionResponse, error)

// UpdateWorkerBuildIDCompatability **IN DEVELOPMENT**
// UpdateWorkerBuildIDCompatability
// Allows you to update the worker-build-id based version sets for a particular task queue. This is used in
// conjunction with workers who specify their build id and thus opt into the feature. For more, see: <doc link>
// conjunction with workers who specify their build id and thus opt into the feature.
// NOTE: Experimental
UpdateWorkerBuildIDCompatability(ctx context.Context, options *UpdateWorkerBuildIDCompatabilityOptions) error

// GetWorkerBuildIDCompatability **IN DEVELOPMENT**
// GetWorkerBuildIDCompatability
// Returns the worker-build-id based version sets for a particular task queue.
// NOTE: Experimental
GetWorkerBuildIDCompatability(ctx context.Context, options *GetWorkerBuildIDCompatabilityOptions) (*WorkerBuildIDVersionSets, error)

// CheckHealth performs a server health check using the gRPC health check
Expand Down
2 changes: 1 addition & 1 deletion internal/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ type (

// UpdateWorkerBuildIDCompatability allows you to update the worker-build-id based version sets for a particular
// task queue. This is used in conjunction with workers who specify their build id and thus opt into the
// feature. For more, see: <doc link>
// feature.
UpdateWorkerBuildIDCompatability(ctx context.Context, options *UpdateWorkerBuildIDCompatabilityOptions) error

// GetWorkerBuildIDCompatability returns the worker-build-id based version sets for a particular task queue.
Expand Down
2 changes: 1 addition & 1 deletion internal/internal_workflow_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@ func (wc *WorkflowClient) ResetWorkflowExecution(ctx context.Context, request *w

// UpdateWorkerBuildIDCompatability allows you to update the worker-build-id based version sets for a particular
// task queue. This is used in conjunction with workers who specify their build id and thus opt into the
// feature. For more, see: <doc link>
// feature.
func (wc *WorkflowClient) UpdateWorkerBuildIDCompatability(ctx context.Context, options *UpdateWorkerBuildIDCompatabilityOptions) error {
if err := wc.ensureInitialized(); err != nil {
return err
Expand Down
3 changes: 1 addition & 2 deletions internal/worker.go
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,10 @@ type (
// workflow or activities.
DisableRegistrationAliasing bool

// **IN DEVELOPMENT**
// Optional: If set, opts this worker into the worker build id based versioning
// feature. It will only operate on workflows it claims to be compatible with.
// Additionally, if this is set it will serve as the binary checksum for the worker.
// For more, see: <doc link>
// NOTE: Experimental
BuildIDForVersioning string
}
)
Expand Down

0 comments on commit 7b59d6f

Please sign in to comment.