Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getVersion search attribute bloat #1052

Closed
Quinn-With-Two-Ns opened this issue Feb 27, 2023 · 2 comments
Closed

Fix getVersion search attribute bloat #1052

Quinn-With-Two-Ns opened this issue Feb 27, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Quinn-With-Two-Ns
Copy link
Contributor

Quinn-With-Two-Ns commented Feb 27, 2023

Java and Go accumulate values in the TemporalChangeVersion search attribute every time a getVersion call is made.

The search attribute value size is capped, which causes user workflows to get stuck in a WFT failure loop without an easy way of out of this situation. If we hit the size limit we should stop adding new versions to TemporalChangeVersion and log a clear error/warning when situation reached.

@Quinn-With-Two-Ns Quinn-With-Two-Ns added the enhancement New feature or request label Feb 27, 2023
@Quinn-With-Two-Ns Quinn-With-Two-Ns self-assigned this Feb 27, 2023
@cretz
Copy link
Member

cretz commented Feb 27, 2023

If we hit the size limit we should stop adding new versions to TemporalChangeVersion

Or remove the oldest from the list. But either way is fine, we just need to log a clear error/warning when situation reached.

@Quinn-With-Two-Ns
Copy link
Contributor Author

Yep good point, I noted the requirement to log as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants