Reduce SA bloat on GetVersion #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
version-sa-bloat
branch
from
af7b0cf to
08fa4c4
Compare
|
resolves: #1052 |
internal/internal_event_handlers.go
Outdated
| // Server has a limit for the max size of a single search attribute value. If we exceed the default limit | ||
| // do not try to upsert as it will cause the workflow to fail. | ||
| updateSearchAttribute := true | ||
| if wc.sdkFlags.tryUse(LimitChangeVersionSASize, !wc.isReplay) && len(attr.IndexedFields[TemporalChangeVersion].GetData()) >= changeVersionSearchAttrSizeLimit { |
There was a problem hiding this comment.
I'll note this will change the behavior for new WFT not new workflows
cretz
reviewed
Mar 8, 2023
cretz
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
LGTM, but would like either @Sushisource or @bergundy to review the SDK flag behavior just in case.
Sushisource
approved these changes
Mar 9, 2023
Comment on lines
+241
to
+242
| // If a flag is not recognized (value is too high or not defined), it must fail the workflow task | ||
| return false, "", nil, errors.New("could not recognize SDK flag") |
There was a problem hiding this comment.
Hmm, I'm actually not doing this currently and probably should.
There was a problem hiding this comment.
oh that reminds me I wanted to add a test for this case, I'll do that quickly
Comment on lines
287
to
+288
| // TODO(maxim): Refactor to return a struct instead of multiple parameters | ||
| func (eh *history) NextCommandEvents() (result []*historypb.HistoryEvent, markers []*historypb.HistoryEvent, binaryChecksum string, err error) { | ||
| func (eh *history) NextCommandEvents() (result []*historypb.HistoryEvent, markers []*historypb.HistoryEvent, binaryChecksum string, sdkFlags []sdkFlag, err error) { |
There was a problem hiding this comment.
Might be a good time to do this TODO
There was a problem hiding this comment.
I did try this and didn't find it to much cleaner because this code uses named return values heavily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce SA bloat on GetVersion. This PR implements 3 new features to the Go SDK.
GetVersionif that search attribute would exceed the default size limit