Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update internal timers to use NewTimerWithOptions and a summary #1602

Closed
cretz opened this issue Aug 19, 2024 · 1 comment · Fixed by #1618
Closed

Update internal timers to use NewTimerWithOptions and a summary #1602

cretz opened this issue Aug 19, 2024 · 1 comment · Fixed by #1618
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Aug 19, 2024

Describe the solution you'd like

Since #1597, there is now a way to provide a summary for a timer, so we should do so for internal timers we create inside the SDK
@cretz cretz added the enhancement New feature or request label Aug 19, 2024
@cretz cretz mentioned this issue Aug 19, 2024
Merged
@Quinn-With-Two-Ns
Copy link
Contributor

We should probably also expose s summary on AwaitWithTimeout as well so the timer is creates can have specific details. For internal and external use.

@yuandrew yuandrew mentioned this issue Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update internal timers to use NewTimerWithOptions yuandrew/sdk-go
2 participants
@cretz @Quinn-With-Two-Ns