Update internal timers to use NewTimerWithOptions #1618
Merged
+120
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuandrew
commented
Sep 3, 2024
cretz
reviewed
Sep 4, 2024
cretz
reviewed
Sep 4, 2024
yuandrew
commented
Sep 4, 2024
cretz
reviewed
Sep 5, 2024
cretz
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
LGTM, may want to wait until @Quinn-With-Two-Ns's approval though
Quinn-With-Two-Ns
approved these changes
Sep 9, 2024
|
@yuandrew - Looks like you can merge if/when CI passes (I kicked it again, looks like flaky test) |
|
@cretz looks like there's a regression with the |
ReyOrtiz
pushed a commit
to ReyOrtiz/temporal-sdk-go
that referenced
this pull request
Dec 5, 2024
* switch internal timers to use options, expose StaticSummary and StaticDetails * plumb options through AwaitWithTimeout * create new API, don't break existing API * missed a spot to remove API change * add experimental tag, fix test * take out StaticSummary StaticDetails changes * missed a few spots * remove duplicate code * cleaner code share * AwaitOptions * alias AwaitOptions in public package * add unit test * wip * test works with prettifyString logging * clean up * no need for unit test now that we have better E2E test * remove print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
NewTimertoNewTimerWithOptionsAwaitWithTimeoutAndOptionto allow specifying options for the underlyingtimerthat's createdWhy?
Because there's now a way to give a summary for internal timers, change internal code to use the new timer with summary command.
Checklist
Closes Update internal timers to use NewTimerWithOptions and a summary #1602
How was this tested: