Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove poll failure log on explicit worker stop #882

Closed
cretz opened this issue Aug 9, 2022 · 0 comments · Fixed by #894
Closed

Remove poll failure log on explicit worker stop #882

cretz opened this issue Aug 9, 2022 · 0 comments · Fixed by #894
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Aug 9, 2022

Is your feature request related to a problem? Please describe.

Right now we log:

2022-08-09T10:54:28.389-0700	WARN	harness/log.go:50	Failed to poll for task.	{"Namespace": "sdk-features-ns-8fdd637a-5b7f-448f-8ca9-039f8583f829", "TaskQueue": "sdk-features-query/timeout_due_to_no_active_workers-cad8cd2c-5d1d-4983-bd3a-937c88fec7db", "WorkerID": "2107561@monolith-linux@", "WorkerType": "ActivityWorker", "Error": "worker stopping"}

We should stop
@cretz cretz added the enhancement New feature or request label Aug 9, 2022
cretz added a commit to cretz/temporal-sdk-go that referenced this issue Aug 29, 2022
@cretz
Stop logging poller errors after stop
60e4e24 
Fixes temporalio#882
@cretz cretz mentioned this issue Aug 29, 2022
Merged
@cretz cretz closed this as completed in 7f1b18f Aug 30, 2022
@Quinn-With-Two-Ns Quinn-With-Two-Ns mentioned this issue Dec 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop logging poller errors after stop cretz/temporal-sdk-go
1 participant
@cretz