Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some documentation fixes #1004

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Fix the count in ScheduleListEntry

Disallow setting MaxConcurrentWorkflowTaskExecutionSize to one because it doesn't work

Looks like we limit the number of pollers to MaxConcurrentWorkflowTaskExecutionSize so the worker will only be polling on the sticky queue, so it will never pick up work. So the root cause is the same reason we need 2 workflow task pollers
Note: Technically we do create maxConcurrentWorkflowTaskPollers number of pollers , but only really start MaxConcurrentWorkflowTaskExecutionSize
MaxConcurrentWorkflowTaskExecutionSize should never be less than MaxConcurrentWorkflowTaskPollers
We call this out here https://docs.temporal.io/application-development/worker-performance#invariants but say it only applies to java which is not true it also applies to the go sdk from reading the code.
Basically we need to document this and probably force MaxConcurrentWorkflowTaskExecutionSize to be greater than MaxConcurrentWorkflowTaskPollers

This change is technically a breaking change, but their workers were not able to process workflows anyway so seems reasonable.

We could force MaxConcurrentWorkflowTaskExecutionSize to be greater than MaxConcurrentWorkflowTaskPollers theoretically could cause users working workers to panic so I held off on it.

resolves #1003

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner January 16, 2023 10:50
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from dnr January 16, 2023 10:50
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 002db6e into temporalio:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting MaxConcurrentWorkflowTaskExecutionSize to 1 results in worker not executing any tasks
2 participants