Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContextPropagators option for replay tests #1019

Merged

Conversation

jlegrone
Copy link
Contributor

What was changed

This PR enables setting ContextPropagators on workflow replay options, which can currently only be set on client.Options passed to a worker.

Why?

Context propagators can extract information from workflow headers and modify workflow contexts. This is important for workflow replay in some cases, because information in a workflow.Context may be used to modify workflow behavior, eg. workflow code that performs role based access control based on claims in workflow headers.

Checklist

How was this tested:

This was tested in our internal environment where workflow replay was previously failing due to missing context propagators.

@jlegrone jlegrone requested a review from a team as a code owner January 30, 2023 20:41
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

@cretz cretz merged commit 9a541ee into temporalio:master Jan 30, 2023
@jlegrone jlegrone deleted the jlegrone/replay-with-context-propagators branch January 30, 2023 21:08
jlegrone added a commit to jlegrone/sdk-go that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants