Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headings on activity docs #1022

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 44 additions & 47 deletions activity/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ An Activity is an implementation of a task to be performed as part of a larger W
what an Activity can do. In the context of a Workflow, it is in the Activities where all operations that affect the
desired results must be implemented.

Overview
# Overview

Temporal Go SDK does all the heavy lifting of handling the async communication between the Temporal
managed service and the Worker running the Activity. As such, the implementation of the Activity can, for the most
Expand All @@ -49,14 +49,14 @@ string parameter, appends a word to it and then returns the result.

The following sections explore the elements of the above code.

Declaration
# Declaration

In the Temporal programing model, an Activity is implemented with a function. The function declaration specifies the
parameters the Activity accepts as well as any values it might return. An Activity function can take zero or many
Activity specific parameters and can return one or two values. It must always at least return an error value. The
Activity function can accept as parameters and return as results any serializable type.

func SimpleActivity(ctx context.Context, value string) (string, error)
func SimpleActivity(ctx context.Context, value string) (string, error)

The first parameter to the function is context.Context. This is an optional parameter and can be omitted. This
parameter is the standard Go context.
Expand All @@ -68,53 +68,53 @@ serializable, which essentially means that params can’t be channels, functions
The Activity declares two return values: (string, error). The string return value is used to return the result of the
Activity. The error return value is used to indicate an error was encountered during execution.

Implementation
# Implementation

There is nothing special about Activity code. You can write Activity implementation code the same way you would any
other Go service code. You can use the usual loggers and metrics collectors. You can use the standard Go concurrency
constructs.

Failing the Activity
# Failing the Activity

To mark an Activity as failed, all that needs to happen is for the Activity function to return an error via the error
return value.

Activity Heartbeating
# Activity Heartbeating

For long running Activities, Temporal provides an API for the Activity code to report both liveness and progress back to
the Temporal managed service.

progress := 0
for hasWork {
// send heartbeat message to the server
activity.RecordHeartbeat(ctx, progress)
// do some work
...
progress++
}
progress := 0
for hasWork {
// send heartbeat message to the server
activity.RecordHeartbeat(ctx, progress)
// do some work
...
progress++
}

When the Activity times out due to a missed heartbeat, the last value of the details (progress in the above sample) is
returned from the workflow.ExecuteActivity function as the details field of TimeoutError with TimeoutType_HEARTBEAT.

It is also possible to heartbeat an Activity from an external source:

// instantiate a Temporal service Client
client.Client client = client.Dial(...)
// instantiate a Temporal service Client
client.Client client = client.Dial(...)

// record heartbeat
err := client.RecordActivityHeartbeat(ctx, taskToken, details)
// record heartbeat
err := client.RecordActivityHeartbeat(ctx, taskToken, details)

It expects an additional parameter, "taskToken", which is the value of the binary "TaskToken" field of the
"ActivityInfo" struct retrieved inside the Activity (GetActivityInfo(ctx).TaskToken). "details" is the serializable
payload containing progress information.

Activity Cancellation
# Activity Cancellation

When an Activity is canceled (or its Workflow execution is completed or failed) the context passed into its function
is canceled which sets its Done channel’s closed state. So an Activity can use that to perform any necessary cleanup
and abort its execution. Currently cancellation is delivered only to Activities that call RecordHeartbeat.

Async/Manual Activity Completion
# Async/Manual Activity Completion

In certain scenarios completing an Activity upon completion of its function is not possible or desirable.

Expand All @@ -136,64 +136,61 @@ There are 2 parts to implementing an asynchronously completed Activity. The firs
the information necessary to be able to be completed from an external system and notify the Temporal service that it is
waiting for that outside callback:

// retrieve Activity information needed to complete Activity asynchronously
activityInfo := activity.GetInfo(ctx)
taskToken := activityInfo.TaskToken
// retrieve Activity information needed to complete Activity asynchronously
activityInfo := activity.GetInfo(ctx)
taskToken := activityInfo.TaskToken

// send the taskToken to external service that will complete the Activity
...
// send the taskToken to external service that will complete the Activity
...

// return from Activity function indicating the Temporal should wait for an async completion message
return "", activity.ErrResultPending
// return from Activity function indicating the Temporal should wait for an async completion message
return "", activity.ErrResultPending

The second part is then for the external service to call the Temporal service to complete the Activity. To complete the
Activity successfully you would do the following:

// instantiate a Temporal service Client
// the same client can be used complete or fail any number of Activities
client.Client client = client.NewClient(...)
// instantiate a Temporal service Client
// the same client can be used complete or fail any number of Activities
client.Client client = client.NewClient(...)

// complete the Activity
client.CompleteActivity(taskToken, result, nil)
// complete the Activity
client.CompleteActivity(taskToken, result, nil)

And here is how you would fail the Activity:

// fail the Activity
client.CompleteActivity(taskToken, nil, err)
// fail the Activity
client.CompleteActivity(taskToken, nil, err)

The parameters of the CompleteActivity function are:

- taskToken: This is the value of the binary “TaskToken” field of the
“ActivityInfo” struct retrieved inside the Activity.
- result: This is the return value that should be recorded for the Activity.
The type of this value needs to match the type of the return value
declared by the Activity function.
The type of this value needs to match the type of the return value
declared by the Activity function.
- err: The error code to return if the Activity should terminate with an
error.

If error is not null the value of the result field is ignored.

For a full example of implementing this pattern see the Expense sample.

Registration
# Registration

In order to for some Workflow execution to be able to invoke an Activity type, the Worker process needs to be aware of
all the implementations it has access to. To do that, create a Worker and register the Activity like so:

```
c, err := client.Dial(client.Options{})
if err != nil {
log.Fatalln("unable to create Temporal client", err)
}
defer c.Close()
w := worker.New(c, "SomeTaskQueue", worker.Options{})
w.RegisterActivity(SomeActivityFunction)
```
c, err := client.Dial(client.Options{})
if err != nil {
log.Fatalln("unable to create Temporal client", err)
}
defer c.Close()
w := worker.New(c, "SomeTaskQueue", worker.Options{})
w.RegisterActivity(SomeActivityFunction)

This call essentially creates an in-memory mapping inside the Worker process between the fully qualified function name
and the implementation. Unlike in Amazon SWF, Workflow and Activity types are not registered with the managed service.
If the Worker receives a request to start an Activity execution for an Activity type it does not know it will fail that
request.

*/
package activity