workflowcheck: mark some fmt functions as deterministic #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
workflowcheck-sprintf
branch
from
13ee776 to
8d14341
Compare
cretz
reviewed
Feb 14, 2023
| "fmt.Errorf": false, | ||
| "fmt.Sprintf": false, | ||
| "fmt.Sprint": false, | ||
| "fmt.Sprintln": false, |
There was a problem hiding this comment.
May want to add each of these being called in a method in contrib/tools/workflowcheck/determinism/testdata/src/a/calls.go but not that big of a deal.
Also, may want to add the Append and Sscan funcs here too
There was a problem hiding this comment.
Yeah, just for peace of mind, can we add the following to the bottom of contrib/tools/workflowcheck/determinism/testdata/src/a/calls.go:
func SafeFmtCall() {
fmt.Sprintf("foo bar")
}
Quinn-With-Two-Ns
force-pushed
the
workflowcheck-sprintf
branch
from
8d14341 to
9c52284
Compare
cretz
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #980