Fix race condition with eager workflow start and close #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
fix-eager-wf-race
branch
from
ee22519 to
81e05a8
Compare
cretz
approved these changes
Aug 8, 2023
| @@ -951,6 +951,9 @@ func (aw *AggregatedWorker) Start() error { | |||
| if err := aw.workflowWorker.Start(); err != nil { | |||
| return err | |||
| } | |||
| if aw.client.eagerDispatcher != nil { | |||
There was a problem hiding this comment.
What was the reasoning behind this change? (not that I disagree with it)
There was a problem hiding this comment.
Seems inefficient to register workers that had not started yet and force every eager workflow start attempt to try them over and over. Not a huge optimization, but this code path is also for low latency
There was a problem hiding this comment.
👍 Just making sure it wasn't fixing something I couldn't see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condition in eager WF start reported by
roadrunnerhttps://github.com/roadrunner-server/rr-e2e-tests/actions/runs/5790984816/job/15695006300#step:10:963
removed checking
isWorkerStartedbecausepollerRequestChwill not have any slots if the worker has not started, also moved when the worker is registered to after it is started instead of when it is created.