Add note on heart beating and async activities #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Aug 10, 2023
Comment on lines
+75
to
+76
| // Note: If using asynchronous activity completion, | ||
| // after returning [ErrResultPending] users should heartbeat with [client.Client.RecordActivityHeartbeat] |
There was a problem hiding this comment.
Curious: how are they even doing this if the activity has returned the error?
There was a problem hiding this comment.
They are launching a goroutine in their activity that is eventually trying to heartbeat. It is a poor use of asynchronous activity completion
Quinn-With-Two-Ns
force-pushed
the
note-on-async-completion-and-heartbeat
branch
from
8713646 to
216151e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this multiple times in the past month were users are using
RecordHeartbeatincorrectly