Add NotBefore function to testsuite.MockCallWrapper
#1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
cretz
approved these changes
Nov 27, 2023
internal/workflow_testsuite.go
Outdated
| // NotBefore indicates that a call to this mock must not happen before the given calls have happened as expected. | ||
| // It calls `NotBefore` on the wrapped mock call. | ||
| func (c *MockCallWrapper) NotBefore(calls ...*MockCallWrapper) *MockCallWrapper { | ||
| wrappedCalls := []*mock.Call{} |
There was a problem hiding this comment.
Often best practice to create the slice with a certain len/cap if you know what it will be
There was a problem hiding this comment.
Makes sense. I've changed the code to create a slice with an initial capacity.
|
(will let @Quinn-With-Two-Ns review) |
Quinn-With-Two-Ns
approved these changes
Nov 27, 2023
|
Thanks! Merged main into branch, will merge into main if/when CI succeeds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR adds a
NotBeforemethod to thetestsuite.MockCallWrapper.It indicates that a mock call must not happen before the given set of other mocks have been called as expected.
The actual functionality for this is already implemented in
github.com/stretchr/testify/mock.The new function forwards to the
.NotBefore()method on the wrappedmockobject.Why?
This change further improves the testability of workflows.
It allows to specify the exact sequence that activities and child-workflow executions must happen.
For example, "call activity abc, then execute child-workflow xyz"
Checklist
No issue found.
Added an additional unit test.
Go docs should update automatically.