Include update state machine fields in panic #1327
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Dec 20, 2023
cretz
reviewed
Jan 3, 2024
| @@ -130,7 +130,7 @@ func (up *updateProtocol) requireState(action string, valid ...updateState) { | |||
| return | |||
| } | |||
| } | |||
| panicIllegalState(fmt.Sprintf("invalid action %q in update protocol %v", action, up)) | |||
| panicIllegalState(fmt.Sprintf("invalid action %q in update protocol %+v", action, up)) | |||
There was a problem hiding this comment.
Does this occur for user mistakes or just mistakes we've made internal to the SDK/server? If the former, I would prefer more structure to the message
There was a problem hiding this comment.
Mistakes we have made
cretz
approved these changes
Jan 3, 2024
Quinn-With-Two-Ns
force-pushed
the
include-update-sm-struct
branch
3 times, most recently
from
4130c96 to
ce5fb9d
Compare
Quinn-With-Two-Ns
force-pushed
the
include-update-sm-struct
branch
from
ce5fb9d to
32e62ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include update state machine fields in panic. This will help debug update issues by making it easier to interpret the panics message.