Bump go-api version to fix protojson vuln #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jan 3, 2024
| @@ -10,12 +10,12 @@ require ( | |||
| github.com/pborman/uuid v1.2.1 | |||
| github.com/robfig/cron v1.2.0 | |||
| github.com/stretchr/testify v1.8.4 | |||
| go.temporal.io/api v1.26.1 | |||
| go.temporal.io/api v1.26.1-0.20240103185939-608bdd111e4b | |||
There was a problem hiding this comment.
How can we make sure we don't release the SDK with an untagged API version?
There was a problem hiding this comment.
I'm happy to cut a release of api-go if we're ok with releasing all of temporalio/api-go@v1.26.2...master
There was a problem hiding this comment.
@cretz we can't cut a release of api-go because we haven't released the gogoproto changes into the wild.
There was a problem hiding this comment.
Right, I just want to make sure we remember to tag this before next SDK release
|
Would rather have @Quinn-With-Two-Ns's approval here over my own. He may prefer not to merge this at this time. |
See temporalio/api-go#143 for details
tdeebswihart
force-pushed
the
tds/update-go-api
branch
from
26b2a69 to
9490b29
Compare
Quinn-With-Two-Ns
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I bumped the version of api-go
Why?
To fix the protojson DOS vulns recently patched in the upstream golang/protobuf. See temporalio/api-go#143 for details